Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split history context from retrieved contexts #2393

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

sunbit
Copy link
Contributor

@sunbit sunbit commented Aug 9, 2024

retrieved context will store both text and pointer to original paragraph

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

retrieved context will store both text and pointer to original paragraph
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (c10226c) to head (d0ea7cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2393      +/-   ##
==========================================
+ Coverage   86.60%   86.63%   +0.03%     
==========================================
  Files         373      373              
  Lines       22872    22872              
==========================================
+ Hits        19808    19815       +7     
+ Misses       3064     3057       -7     
Flag Coverage Δ
nucliadb 73.58% <ø> (+0.10%) ⬆️
nucliadb-ingest 29.67% <ø> (ø)
nucliadb-reader 25.38% <ø> (ø)
nucliadb-search 37.53% <ø> (ø)
nucliadb-standalone 47.83% <ø> (ø)
nucliadb-train 46.75% <ø> (ø)
nucliadb-writer 40.69% <ø> (ø)
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.11% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 92.75% <ø> (-1.70%) ⬇️
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 83.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunbit sunbit merged commit 25af312 into main Aug 14, 2024
43 checks passed
@sunbit sunbit deleted the fix_context_on_audit branch August 14, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants