Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rollover state persistence #2395

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Aug 12, 2024

Description

Before, the rollover state was kept in the extra parameter of the Shards protobuf.
Now that we want to rollover not only internal index node shards, but also external indexes, we need to decouple this logic from the shards object.

How was this PR tested?

Integration, unit and local tests.

@lferran lferran requested review from drf7 and Ciniesta August 12, 2024 14:17
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.59%. Comparing base (adb1515) to head (18869cd).
Report is 1 commits behind head on main.

Files Patch % Lines
nucliadb/src/nucliadb/common/cluster/rollover.py 80.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   86.60%   86.59%   -0.01%     
==========================================
  Files         373      373              
  Lines       22874    22902      +28     
==========================================
+ Hits        19811    19833      +22     
- Misses       3063     3069       +6     
Flag Coverage Δ
nucliadb 73.50% <85.91%> (-0.01%) ⬇️
nucliadb-ingest 29.66% <19.71%> (-0.02%) ⬇️
nucliadb-reader 25.37% <19.71%> (-0.01%) ⬇️
nucliadb-search 37.49% <19.71%> (-0.03%) ⬇️
nucliadb-standalone 47.79% <19.71%> (-0.05%) ⬇️
nucliadb-train 46.71% <19.71%> (-0.05%) ⬇️
nucliadb-writer 40.66% <19.71%> (-0.04%) ⬇️
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.11% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 94.44% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 83.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 34dbbe4 into main Aug 12, 2024
43 checks passed
@lferran lferran deleted the refactor-rollover-state-persistence branch August 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants