Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap max number of relations returned #2403

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Aug 19, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@lferran lferran requested a review from a team August 19, 2024 15:49
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (c1b5b9c) to head (3743ab7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
+ Coverage   86.56%   86.59%   +0.02%     
==========================================
  Files         373      373              
  Lines       23077    23066      -11     
==========================================
- Hits        19976    19973       -3     
+ Misses       3101     3093       -8     
Flag Coverage Δ
nucliadb 73.64% <100.00%> (+0.08%) ⬆️
nucliadb-ingest 29.54% <0.00%> (+0.02%) ⬆️
nucliadb-reader 25.29% <0.00%> (+0.01%) ⬆️
nucliadb-search 37.26% <100.00%> (-0.02%) ⬇️
nucliadb-standalone 47.50% <0.00%> (+0.02%) ⬆️
nucliadb-train 46.43% <0.00%> (+0.02%) ⬆️
nucliadb-writer 40.44% <0.00%> (+0.02%) ⬆️
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.11% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 92.75% <ø> (-1.70%) ⬇️
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 83.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 0b327ef into main Aug 20, 2024
51 checks passed
@lferran lferran deleted the relations-results-capping branch August 20, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants