Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove channel concept (python side) #2454

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Remove channel concept (python side) #2454

merged 6 commits into from
Sep 13, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Sep 12, 2024

Description

We’re not using it.
It doubles the number of integration tests we have.
Will speed up our CI

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.26%. Comparing base (31ce460) to head (cc302a7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
+ Coverage   86.20%   86.26%   +0.05%     
==========================================
  Files         373      373              
  Lines       23119    23102      -17     
==========================================
- Hits        19929    19928       -1     
+ Misses       3190     3174      -16     
Flag Coverage Δ
nucliadb 73.79% <100.00%> (+0.05%) ⬆️
nucliadb-ingest 29.29% <100.00%> (-0.03%) ⬇️
nucliadb-reader 25.18% <100.00%> (-0.03%) ⬇️
nucliadb-search 36.94% <100.00%> (-0.02%) ⬇️
nucliadb-standalone 47.32% <100.00%> (-0.03%) ⬇️
nucliadb-train 45.95% <100.00%> (-0.03%) ⬇️
nucliadb-writer 40.27% <100.00%> (-0.03%) ⬇️
nucliadb_dataset 55.31% <ø> (ø)
nucliadb_models 85.14% <ø> (+0.04%) ⬆️
nucliadb_sdk 78.26% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran changed the title Remove channel concept Remove channel concept (from python) Sep 12, 2024
@lferran lferran changed the title Remove channel concept (from python) Remove channel concept (python side) Sep 12, 2024
@lferran lferran requested a review from a team September 12, 2024 15:41
@lferran lferran merged commit da0e790 into main Sep 13, 2024
51 checks passed
@lferran lferran deleted the remove-channel-concept branch September 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants