Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block readers from starting during initial replication #2484

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (ae2ae0c) to head (4f33306).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2484   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files         375      375           
  Lines       23381    23381           
=======================================
  Hits        20174    20174           
  Misses       3207     3207           
Flag Coverage Δ
nucliadb 74.06% <ø> (ø)
nucliadb-ingest 29.10% <ø> (ø)
nucliadb-reader 25.03% <ø> (ø)
nucliadb-search 37.23% <ø> (ø)
nucliadb-standalone 47.02% <ø> (ø)
nucliadb-train 45.65% <ø> (ø)
nucliadb-writer 39.97% <ø> (ø)
nucliadb_dataset 55.31% <ø> (ø)
nucliadb_models 85.13% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit e00b8fa into main Sep 24, 2024
51 checks passed
@javitonino javitonino deleted the replication_shard_creation branch September 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants