Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply hidden_resources to suggest queries #2487

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.20%. Comparing base (e00b8fa) to head (ecdeb30).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/search/search/query.py 90.00% 1 Missing ⚠️
nucliadb_models/src/nucliadb_models/labels.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
- Coverage   86.22%   86.20%   -0.03%     
==========================================
  Files         375      375              
  Lines       23381    23392      +11     
==========================================
+ Hits        20161    20164       +3     
- Misses       3220     3228       +8     
Flag Coverage Δ
nucliadb 73.99% <93.33%> (+<0.01%) ⬆️
nucliadb-ingest 29.09% <6.66%> (-0.02%) ⬇️
nucliadb-reader 25.01% <6.66%> (-0.02%) ⬇️
nucliadb-search 37.25% <60.00%> (+0.02%) ⬆️
nucliadb-standalone 47.00% <20.00%> (-0.03%) ⬇️
nucliadb-train 45.63% <20.00%> (-0.03%) ⬇️
nucliadb-writer 39.95% <20.00%> (-0.02%) ⬇️
nucliadb_dataset 55.31% <ø> (ø)
nucliadb_models 85.08% <0.00%> (-0.05%) ⬇️
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 87.24% <ø> (-1.79%) ⬇️
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit deb6751 into main Sep 24, 2024
50 of 51 checks passed
@javitonino javitonino deleted the hidden_in_suggest branch September 24, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants