Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector search metadata serialization #2570

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Oct 23, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team October 23, 2024 11:09
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (5eebea5) to head (cf13a11).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
- Coverage   86.22%   86.11%   -0.12%     
==========================================
  Files         376      376              
  Lines       23559    23559              
==========================================
- Hits        20313    20287      -26     
- Misses       3246     3272      +26     
Flag Coverage Δ
nucliadb 73.51% <ø> (-0.18%) ⬇️
nucliadb-ingest 28.85% <ø> (ø)
nucliadb-reader 24.84% <ø> (ø)
nucliadb-search 37.60% <ø> (-0.02%) ⬇️
nucliadb-standalone 46.85% <ø> (ø)
nucliadb-train 44.94% <ø> (ø)
nucliadb-writer 39.40% <ø> (-0.01%) ⬇️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 85.04% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 9c18926 into main Oct 23, 2024
53 checks passed
@lferran lferran deleted the fix-vector-search-metadata-serialization branch October 23, 2024 12:10
jotare added a commit that referenced this pull request Oct 28, 2024
jotare added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants