Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated features from search #2618

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Nov 11, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team November 11, 2024 10:10
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.08%. Comparing base (50d375e) to head (a60f53d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2618      +/-   ##
==========================================
- Coverage   86.12%   86.08%   -0.05%     
==========================================
  Files         377      377              
  Lines       23792    23765      -27     
==========================================
- Hits        20492    20457      -35     
- Misses       3300     3308       +8     
Flag Coverage Δ
nucliadb 73.61% <ø> (ø)
nucliadb-ingest 28.51% <ø> (ø)
nucliadb-reader 24.54% <ø> (ø)
nucliadb-search 37.61% <ø> (ø)
nucliadb-standalone 46.61% <ø> (ø)
nucliadb-train 44.74% <ø> (ø)
nucliadb-writer 39.13% <ø> (-0.01%) ⬇️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 84.82% <ø> (-0.29%) ⬇️
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 87.24% <ø> (-1.79%) ⬇️
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare force-pushed the remove-deprecated-features-from-search branch from e37e08c to e0cc3a6 Compare November 11, 2024 11:57
@jotare jotare merged commit 2591ec8 into main Nov 11, 2024
46 checks passed
@jotare jotare deleted the remove-deprecated-features-from-search branch November 11, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants