Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nidx binding #2620

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Nidx binding #2620

merged 9 commits into from
Nov 12, 2024

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@javitonino javitonino changed the base branch from main to dev November 11, 2024 15:16
@javitonino javitonino changed the base branch from dev to nidx_search_test November 11, 2024 15:16
@javitonino javitonino marked this pull request as ready for review November 12, 2024 11:36
@javitonino javitonino changed the base branch from nidx_search_test to dev November 12, 2024 11:40
@javitonino javitonino changed the base branch from dev to nidx_search_test November 12, 2024 11:47
nucliadb/src/nucliadb/common/cluster/settings.py Outdated Show resolved Hide resolved
Base automatically changed from nidx_search_test to dev November 12, 2024 15:04
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 54.36893% with 47 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (201f6bd) to head (5fd52c9).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/common/nidx.py 51.76% 41 Missing ⚠️
nucliadb/src/nucliadb/search/requesters/utils.py 40.00% 3 Missing ⚠️
nucliadb/src/nucliadb/common/cluster/manager.py 33.33% 2 Missing ⚠️
nucliadb/src/nucliadb/ingest/orm/knowledgebox.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2620      +/-   ##
==========================================
- Coverage   86.10%   85.99%   -0.12%     
==========================================
  Files         377      377              
  Lines       23765    23843      +78     
==========================================
+ Hits        20464    20504      +40     
- Misses       3301     3339      +38     
Flag Coverage Δ
nucliadb 73.51% <54.36%> (-0.11%) ⬇️
nucliadb-ingest 28.58% <44.66%> (+0.07%) ⬆️
nucliadb-reader 24.63% <44.66%> (+0.08%) ⬆️
nucliadb-search 37.64% <46.60%> (+0.03%) ⬆️
nucliadb-standalone 46.63% <53.39%> (+0.02%) ⬆️
nucliadb-train 44.76% <49.51%> (+0.01%) ⬆️
nucliadb-writer 39.15% <44.66%> (+0.02%) ⬆️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 84.82% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit 13d185b into dev Nov 12, 2024
40 of 42 checks passed
@javitonino javitonino deleted the nidx_binding branch November 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants