Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index only upon processing message received #2641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Nov 15, 2024

Description

We no longer need to index anything when ingesting writer messages, as the catalog is responsible for showing the title and the labels to the user after an upload/resource creation request is finished.

Also, when a kb is configured with an external index provider, we no longer need to index on our index either.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.48%. Comparing base (7ca8964) to head (415352c).

Files with missing lines Patch % Lines
...iadb/src/nucliadb/ingest/orm/processor/__init__.py 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
- Coverage   86.48%   86.48%   -0.01%     
==========================================
  Files         376      376              
  Lines       23587    23584       -3     
==========================================
- Hits        20400    20397       -3     
  Misses       3187     3187              
Flag Coverage Δ
nucliadb-reader 24.07% <30.76%> (-0.48%) ⬇️
nucliadb-standalone 46.53% <30.76%> (-0.33%) ⬇️
nucliadb_models 84.85% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (+1.78%) ⬆️
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant