Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key share refreshing ceremony refactor #175

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Feb 5, 2024

Type of PR:

  • Refactor
  • Feature

Required reviews:

  • 1

What this does:

  • Attempts to hide some of the cryptographic primitives behind newtype structs
  • This in turn caused some yet unsolved problems with serde
    • serde can't handle serde_as for crate::* for some reason. external_crate::* works just fine
  • Adds intermediate design for refreshing and recovery API. No bindings yet, to be done after other changes (verification) take place.
    • PrivateKeyShare and its derivatives used in refreshing and recovery are now a part of the public API. This should help decouple them from AggregateTranscript.
    • The "legacy" methods for creating decrypting shares etc., through AggregateTranscript are not deprecated yet - Awaiting more details on a new design, to be addressed in future PR.

Issues fixed/closed:

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 121 lines in your changes are missing coverage. Please review.

Comparison is base (72b8484) 78.28% compared to head (779a7bb) 79.76%.
Report is 1 commits behind head on main.

Files Patch % Lines
ferveo/src/bindings_python.rs 63.15% 49 Missing ⚠️
ferveo/src/api.rs 92.81% 47 Missing ⚠️
ferveo-tdec/src/decryption.rs 26.31% 14 Missing ⚠️
ferveo/src/bindings_wasm.rs 0.00% 5 Missing ⚠️
ferveo/src/refresh.rs 98.67% 3 Missing ⚠️
ferveo/src/dkg.rs 97.70% 2 Missing ⚠️
ferveo-common/src/keypair.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   78.28%   79.76%   +1.47%     
==========================================
  Files          24       24              
  Lines        5066     5856     +790     
==========================================
+ Hits         3966     4671     +705     
- Misses       1100     1185      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cygnusv cygnusv changed the base branch from main to rocknroll March 19, 2024 09:40
Copy link
Member

@cygnusv cygnusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! This is the foundation for the work for Refresh & Recovery, laying out a better codebase to accommodate the required changes

@cygnusv cygnusv merged commit 2c97934 into nucypher:rocknroll Mar 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol objects and methods for handling share updates between participants
3 participants