-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key share refreshing ceremony refactor #175
Key share refreshing ceremony refactor #175
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 78.28% 79.76% +1.47%
==========================================
Files 24 24
Lines 5066 5856 +790
==========================================
+ Hits 3966 4671 +705
- Misses 1100 1185 +85 ☔ View full report in Codecov by Sentry. |
da8614a
to
039f329
Compare
e1f6ac9
to
cf281c4
Compare
cf281c4
to
779a7bb
Compare
779a7bb
to
4713848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! This is the foundation for the work for Refresh & Recovery, laying out a better codebase to accommodate the required changes
Type of PR:
Required reviews:
What this does:
newtype
structsserde
serde
can't handleserde_as
forcrate::*
for some reason.external_crate::*
works just finePrivateKeyShare
and its derivatives used in refreshing and recovery are now a part of the public API. This should help decouple them fromAggregateTranscript
.AggregateTranscript
are not deprecated yet - Awaiting more details on a new design, to be addressed in future PR.Issues fixed/closed:
Why it's needed:
Notes for reviewers: