Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IP lookup webservice to one that preferably returns IPv4 over … #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hypnotortoise
Copy link

@hypnotortoise hypnotortoise commented Mar 11, 2024

…IPv6, when both are available.

This is required as ursulas cli option for "rest-host" expects an IPv4 (see https://github.com/nucypher/nucypher/blob/736f8f9cbbe1eb06bb071b9d8eec6eacfc2e79a6/nucypher/utilities/networking.py#L42-L48)

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Changes the URI request URL to something accessible for hosts that contain both IPv6/IPv4 global interfaces, to return the IPv4 variant.

Issues fixed/closed:
None

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

As long as TACo node does not accept IPv6 binding address for rest-host, this is a requirement for hosts that contain both IPv6/IPv4 global interfaces.

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

No. Only replacement of ip lookup webservice that is queried for IPv4 public address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant