-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from ethers-v5
to viem
#421
base: main
Are you sure you want to change the base?
Conversation
f4f9bd8
to
0a33a66
Compare
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
271d364
to
eb9cc4e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 88.00% 87.89% -0.12%
==========================================
Files 33 33
Lines 2702 2767 +65
Branches 233 239 +6
==========================================
+ Hits 2378 2432 +54
- Misses 293 300 +7
- Partials 31 35 +4 ☔ View full report in Codecov by Sentry. |
c76216e
to
4806ac4
Compare
4806ac4
to
8edd523
Compare
8edd523
to
1fb32bd
Compare
Currently fails due to some incompatibility between
|
Type of PR:
Required reviews:
What this does:
ethers-v5
withviem
WalletClient
andPublicClient
Why it's needed:
Notes for reviewers:
tapir
CI job #445 to keep this PR tested (can drop these commits if needed)ethers
usagetypechain
usage (based onethers
)abitype/zod
to validatefunctionAbi
instead of relying onethers
ethers-v5
toviem
#271