Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty lines from changelog before parsing #1097

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Remove empty lines from changelog before parsing #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/Nuke.Common/ChangeLog/ChangeLogTasks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using JetBrains.Annotations;
using NuGet.Versioning;
Expand Down Expand Up @@ -46,7 +47,7 @@ public static string GetNuGetReleaseNotes(string changelogFile, GitRepository re
[Pure]
public static IReadOnlyList<ReleaseNotes> ReadReleaseNotes(string changelogFile)
{
var lines = TextTasks.ReadAllLines(changelogFile).ToList();
var lines = File.ReadAllLines(changelogFile).Where(x => !x.IsNullOrWhiteSpace()).ToList();
var releaseSections = GetReleaseSections(lines).ToList();

Assert.True(releaseSections.Any(), "Changelog should have at least one release note section");
Expand Down