ChangelogTasks Unit Tests and Fixes

[sandrofigo]

• Adds unit tests for ChangelogTasks
• Fixes ReleaseSection end index when changelog contains empty lines
• Fixes ExtractChangelogSectionNotes not throwing the intended exception
• Fixes IsEmpty property on ReleaseNotes when Notes are empty strings

Closes #1099

I confirm that the pull-request:

• Follows the contribution guidelines
• Is based on my own work
• Is in compliance with my employer

[matkoch]

Could you add some test cases for the format that this project uses? I.e., without sub-headings for Added etc.

[sandrofigo]

@matkoch I have added two variants for the NUKE changelog flavor.

[sandrofigo]

Ready to merge again after rebasing onto develop.

@matkoch Is it intended that I keep the feature branch up-to-date manually with the develop branch by rebasing and force pushing once in a while?

[matkoch]

Hi @sandrofigo
no you don't need to do anything. I do rebases myself (also noted in the contribution guidelines). I'll merge this for next release for sure.

[sandrofigo]

@matkoch It's a bummer that this PR didn't make it into the new release. Let me know if there is something I need to change or when you plan to include this.

[matkoch]

Sorry but I really needed to get all the pending work released. Yes, I also merged some recent PRs, but this one takes a bit more time to review. In any case, I expect there will be reports about this release, so I'm sure another release will follow shortly!

[matkoch]

@sandrofigo, this change has broken version updates.

I reverted some changes and also deleted some tests. If you want, feel free to bring them back. For my purpose, the task is working as intended again.

[sandrofigo]

@matkoch I will try to come up with a fix for FinalizeChangelog() and UpdateVersionSummary() and would also readd the unit tests/fixes.

[sandrofigo]

@matkoch Have a look at this PR #1250 and let me know what you think.