Fix #1186 Fixing signtool.exe path for new windows kits

[gustavocalheiros]

I look inside the path of the latest Windows Kit major version (in this case "10") and check in all the minor version folders (for example "10.0.22621.0", "10.0.16299.0"), and get the last one that contains the file "signtool.exe".

if nothing is found, I fallback on the previous code.

I confirm that the pull-request:

• Follows the contribution guidelines
• Is based on my own work
• Is in compliance with my employer

[gustavocalheiros]

Fix #1186

[matkoch]

Could you unify the code to only make use of GlobFiles ?

[gustavocalheiros]

yep, will do it in the next days.

[gustavocalheiros]

@matkoch do you mind if we drop the support to old versions of the Windows Kit (I mean support only 10.*) ?

PS: Windows Kit 10 is the current version of the SDK for windows 10 and 11.

[matkoch]

fine i guess

[gustavocalheiros]

@matkoch done

[gustavocalheiros]

hello @matkoch, any chance this PR will be merged soon?

[MichaeIDietrich]

Shouldn't we order by version number first before using LastOrDefault?

[gustavocalheiros]

the order returned is naturally the alphabetical order, meaning version 10.0.22 will be after version 10.0.17.

[MichaeIDietrich]

Thanks for the info, I did not know it's already ordered. 👍

[MichaeIDietrich]

What do you think about adding support for using the signtool.exe from these two NuGets?
https://www.nuget.org/packages/Microsoft.Windows.SDK.BuildTools
https://www.nuget.org/packages/signtool

[gustavocalheiros]

What do you think about adding support for using the signtool.exe from these two NuGets? https://www.nuget.org/packages/Microsoft.Windows.SDK.BuildTools https://www.nuget.org/packages/signtool

@MichaeIDietrich Do you think it is possible to the user to run nuke-build having no SDK kit installed?
if yes, I'm ok to add support only to the 1st one (official microsoft package). What do you think?

[gpailler]

Hello @gustavocalheiros, I would say yes. The Microsoft SDK is not a prerequisite for Nuke Build

[MichaeIDietrich]

Yes, the Windows SDK is not needed for Nuke to run. Only a matching .NET SDK is needed to run Nuke.

[gustavocalheiros]

@MichaeIDietrich Pushed support for Microsoft.Windows.SDK.BuildTools

[gustavocalheiros]

path structure for nuget packages is different, for example :
C:\Users\MyUser\ .nuget\packages\microsoft.windows.sdk.buildtools\10.0.20348\bin\10.0.20348\x64\signtool.exe

[gpailler]

@MichaeIDietrich @matkoch
Do you think we should align with the approach taken by other packages, such as XUnit and Codecov, by updating SignTool.json with:

  "nugetPackageId": "Microsoft.Windows.SDK.BuildTools",
  "customExecutable": true,

and implementing the GetProcessToolPath() method?
This would be a breaking change, but it seems to be more in line with the conventions used by other tools.