Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): support sonar.token parameter #1290

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Nov 6, 2023

Sonar is deprecating the usage of sonar.login parameter and one should use sonar.token instead.

https://docs.sonarsource.com/sonarqube/latest/analyzing-source-code/scanners/sonarscanner-for-dotnet/#begin

/d:sonar.token=<token> [recommended] Requires version 5.13+. Use sonar.login for earlier versions.

Specifies the authentication token used to authenticate with to SonarQube. If this argument is added to the begin step, it must also be added to the end step.

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@matkoch matkoch merged commit 433f3e1 into nuke-build:develop Nov 19, 2023
3 of 4 checks passed
@matkoch matkoch added this to the v7.1.0 milestone Nov 19, 2023
@lahma lahma deleted the sonar-token branch November 20, 2023 06:17
@matkoch matkoch added the area:tools issues in this area can easily be fixed in user code label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tools issues in this area can easily be fixed in user code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants