Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate GH Actions root level concurrency group #1299

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Nov 29, 2023

Different image jobs can be cancelling each others when having same job group definition (it's valid to have it on job level too though). Adding a separate concurrency group to root level will cancel the entire workflow including it's jobs instead of jobs fighting against each other will make the default multi-image setup easier.

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@nuke-build nuke-build deleted a comment Dec 6, 2023
@matkoch matkoch force-pushed the develop branch 5 times, most recently from 0231425 to d806295 Compare December 15, 2023 23:12
@matkoch matkoch force-pushed the develop branch 3 times, most recently from 7066bbe to 985de83 Compare January 17, 2024 17:25
@lahma lahma force-pushed the runner-image-cancel-in-progress branch from 892020c to 4b799cc Compare February 19, 2024 13:00
@lahma lahma changed the title Include image name in GH action job concurrency group Move GH Actions concurrency group to root level Feb 19, 2024
@lahma lahma force-pushed the runner-image-cancel-in-progress branch 2 times, most recently from 700489f to bf7b412 Compare February 20, 2024 06:45
@lahma lahma changed the title Move GH Actions concurrency group to root level Add separate GH Actions root level concurrency group Feb 20, 2024
@matkoch matkoch force-pushed the develop branch 4 times, most recently from 0719711 to 6fe1e3b Compare March 20, 2024 01:24
@lahma lahma force-pushed the runner-image-cancel-in-progress branch from bf7b412 to 0e5e320 Compare April 12, 2024 15:06
@matkoch matkoch added this to the v8.0.1 milestone Jun 12, 2024
@matkoch matkoch force-pushed the develop branch 3 times, most recently from 6d02194 to 4bfee84 Compare June 13, 2024 21:33
@matkoch matkoch force-pushed the runner-image-cancel-in-progress branch from 0e5e320 to 9f75d21 Compare July 3, 2024 16:30
@matkoch matkoch merged commit b8273bc into nuke-build:develop Jul 3, 2024
3 of 4 checks passed
@lahma lahma deleted the runner-image-cancel-in-progress branch July 3, 2024 16:32
matkoch pushed a commit that referenced this pull request Jul 3, 2024
matkoch pushed a commit that referenced this pull request Jul 3, 2024
matkoch pushed a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants