Skip to content

Commit

Permalink
chore: add sessionreducer sum example to CI (#114)
Browse files Browse the repository at this point in the history
Signed-off-by: a3hadi <[email protected]>
  • Loading branch information
ayildirim21 authored Mar 25, 2024
1 parent 16c1c10 commit 7009262
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/build-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ on:

jobs:
docker_publish:
# run it only on numaproj/numaflow-go repository
# forked repositories normally don't have the proper permission setup.
if: ${{ github.repository }} == "numaproj/numaflow-go"
name: Build, Tag, and Push Image
runs-on: ubuntu-latest

Expand All @@ -17,9 +20,9 @@ jobs:
"pkg/mapper/examples/even_odd", "pkg/mapper/examples/flatmap", "pkg/mapper/examples/forward_message",
"pkg/mapper/examples/retry", "pkg/mapper/examples/tickgen", "pkg/mapstreamer/examples/flatmap_stream",
"pkg/reducer/examples/counter", "pkg/reducer/examples/sum", "pkg/reducestreamer/examples/counter",
"pkg/reducestreamer/examples/sum", "pkg/sessionreducer/examples/counter", "pkg/sideinput/examples/simple-sideinput/udf",
"pkg/sideinput/examples/simple-sideinput", "pkg/sinker/examples/log", "pkg/sourcer/examples/simple_source",
"pkg/sourcetransformer/examples/assign_event_time", "pkg/sourcetransformer/examples/event_time_filter"
"pkg/reducestreamer/examples/sum", "pkg/sessionreducer/examples/counter", "pkg/sessionreducer/examples/sum",
"pkg/sideinput/examples/simple-sideinput/udf", "pkg/sideinput/examples/simple-sideinput", "pkg/sinker/examples/log",
"pkg/sourcer/examples/simple_source", "pkg/sourcetransformer/examples/assign_event_time", "pkg/sourcetransformer/examples/event_time_filter"
]

steps:
Expand Down
7 changes: 6 additions & 1 deletion development.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,9 @@ files to reflect this new version:
```
After running the above, create a PR for the changes that the script made. Once merged, it will trigger the Docker Publish workflow.
As a result, the correct SDK version will always be printed in the server information logs,
and the example images will always be using the latest changes (due to the local references).
and the example images will always be using the latest changes (due to the local references).

### Adding a New Example

If you add a new example, in order for it to be used by the Docker Publish workflow, add its path
to the `dockerfile_paths` matrix in `build-push.yaml`.

0 comments on commit 7009262

Please sign in to comment.