Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update examples to latest sdk version #148

Merged
merged 1 commit into from
Sep 14, 2024
Merged

chore: update examples to latest sdk version #148

merged 1 commit into from
Sep 14, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Sep 14, 2024

No description provided.

Signed-off-by: Yashash H L <[email protected]>
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't we use local path reference in go.mod for examples?

@vigith
Copy link
Member

vigith commented Sep 14, 2024

Why didn't we use local path reference in go.mod for examples?

@KeranYang do you remember?

Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we still have to give version

@KeranYang
Copy link
Member

@vigith we declare in go,mod required version of numaflow-go, but when building the stable image, we use the local reference. We don't necessarily need to update the version but I am ok with making it up-to-date. cc: @ayildirim21

@KeranYang KeranYang merged commit e14d1a2 into main Sep 14, 2024
3 checks passed
@KeranYang KeranYang deleted the examples branch September 14, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants