feat: Using gRPC Bidirectional Streaming for Map #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
BulkBeing
reviewed
Oct 7, 2024
| select { | ||
| case resp := <-responseCh: | ||
| if err := stream.Send(resp); err != nil { | ||
| log.Printf("failed to send response: %v", err) |
There was a problem hiding this comment.
Suggested change
| log.Printf("failed to send response: %v", err) | |
| log.Printf("Failed to send response: %v", err) |
BulkBeing
reviewed
Oct 7, 2024
pkg/mapper/service.go
Outdated
| break outer | ||
| } | ||
| if err != nil { | ||
| log.Printf("failed to receive request: %v", err) |
There was a problem hiding this comment.
Suggested change
| log.Printf("failed to receive request: %v", err) | |
| log.Printf("Failed to receive request: %v", err) |
BulkBeing
reviewed
Oct 7, 2024
Comment on lines
+75
to
+78
| select { | ||
| case <-grpCtx.Done(): | ||
| break outer | ||
| default: |
There was a problem hiding this comment.
one level indentation can be removed by empty default case.
select {
case <-grpCtx.Done():
break outer
default:
}
BulkBeing
reviewed
Oct 7, 2024
pkg/mapper/service_test.go
Outdated
| }{ | ||
| { | ||
| name: "map_fn_forward_msg", | ||
| name: "sourceTransform_fn_forward_msg", |
There was a problem hiding this comment.
Suggested change
| name: "sourceTransform_fn_forward_msg", | |
| name: "map_fn_forward_msg", |
BulkBeing
reviewed
Oct 7, 2024
pkg/mapper/service_test.go
Outdated
| }, | ||
| { | ||
| name: "map_fn_forward_msg_forward_to_all", | ||
| name: "sourceTransform_fn_forward_msg_forward_to_all", |
There was a problem hiding this comment.
Suggested change
| name: "sourceTransform_fn_forward_msg_forward_to_all", | |
| name: "map_fn_forward_msg_forward_to_all", |
BulkBeing
reviewed
Oct 7, 2024
pkg/mapper/service_test.go
Outdated
| }, | ||
| { | ||
| name: "map_fn_forward_msg_drop_msg", | ||
| name: "sourceTransform_fn_forward_msg_drop_msg", |
There was a problem hiding this comment.
Suggested change
| name: "sourceTransform_fn_forward_msg_drop_msg", | |
| name: "map_fn_forward_msg_drop_msg", |
BulkBeing
approved these changes
Oct 7, 2024
Signed-off-by: Yashash H L <[email protected]>
vigith
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.