feat: bidirectional streaming source #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
vigith
reviewed
Sep 21, 2024
| Assertions.fail("Failed to stop server"); | ||
| } | ||
| } | ||
| // FIXME: once tester kit changes are done for bidirectional streaming source |
There was a problem hiding this comment.
Can you open an issue in numaflow repo to track this?
KeranYang
reviewed
Sep 21, 2024
| for (Offset offset : request.getOffsets()) { | ||
| messages.remove(Longs.fromByteArray(offset.getValue())); | ||
| } | ||
| messages.remove(offset); | ||
| } | ||
|
|
||
| @Override | ||
| public long getPending() { | ||
| // pending messages will be zero for a simple source |
There was a problem hiding this comment.
Please update the comment as well.
Comment on lines
66
to
74
| @Test | ||
| public void testLong() { | ||
| Long l = 1L; | ||
| byte[] bytes = Longs.toByteArray(l); | ||
|
|
||
| Long x = Longs.fromByteArray(bytes); | ||
| Assertions.assertEquals(l, x); | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't need to unit test a library. Please remove it.
| import io.numaproj.numaflow.sourcer.Message; | ||
| import io.numaproj.numaflow.sourcer.Offset; | ||
| import io.numaproj.numaflow.sourcer.SourcerTestKit; | ||
| import org.junit.Ignore; |
| .offsets(offsets).build(); | ||
| simpleSource.ack(ackRequest); | ||
|
|
||
| for (Offset offset : offsets) { |
There was a problem hiding this comment.
please also update the testPending case.
| /** | ||
| * AckRequest request for acknowledging messages. | ||
| */ | ||
| public interface AckRequest { | ||
| /** | ||
| * @return the list of offsets to be acknowledged | ||
| * @return the offsets to be acknowledged |
There was a problem hiding this comment.
Suggested change
| * @return the offsets to be acknowledged | |
| * @return the offset to be acknowledged |
| @Override | ||
| public void onNext(SourceOuterClass.ReadRequest request) { | ||
| // if the request is a handshake, send handshake response. | ||
| if (request.hasHandshake() && request.getHandshake().getSot()) { |
There was a problem hiding this comment.
Can we unit test this branch? Same for ack func below.
| future.complete(true); | ||
| } | ||
| }); | ||
| StreamObserver<SourceOuterClass.ReadRequest> readRequestStreamObserver = sourceStub.readFn( |
There was a problem hiding this comment.
we can exclude SourceTestKit from codcov.
Signed-off-by: Yashash H L <[email protected]>
KeranYang
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.