Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Batch ack requests and sink responses for better performance #149

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Oct 30, 2024

No description provided.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@0a803d7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ava/io/numaproj/numaflow/sinker/SinkerTestKit.java 0.00% 9 Missing ⚠️
...a/io/numaproj/numaflow/sourcer/SourcerTestKit.java 0.00% 6 Missing ⚠️
...main/java/io/numaproj/numaflow/sinker/Service.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage        ?   60.47%           
  Complexity      ?      392           
=======================================
  Files           ?      126           
  Lines           ?     2768           
  Branches        ?      192           
=======================================
  Hits            ?     1674           
  Misses          ?      959           
  Partials        ?      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KeranYang
Copy link
Member

Could you share the performance improvement here? Thanks.

@yhl25 yhl25 merged commit 134414a into main Oct 31, 2024
5 checks passed
@yhl25 yhl25 deleted the batch-ack branch October 31, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants