This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Update to latest swig version (3.0.12 as of 5/10/2017) #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottpurdy
reviewed
May 10, 2017
There was a problem hiding this comment.
- SWIG recommends using prebuilt binary for Windows (it is very hard to build yourself). Make sure you update that as well here:
external/windows64/bin/swig.exe - It looks like the unpacked files are redundant. Can you try removing the unpacked files and seeing if we can just use the extracted files from
external/common/src/swig-3.0.12.tar.gz(which is extracted inexternal/Swig.cmake)
|
Why was this PR closed w/o merging? I'd love to see this updated. @oxtopus ? |
|
See @scottpurdy's comments about what remains. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1293