This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Fix sp compute unchecked input #1389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these fields are entered by user and must exactly match the Input, Columns sizes. Unfortunately, the array is passed as T* so getting the size will be tricky.
breznak
commented
Jan 12, 2018
| // check size of input/output arrays | ||
| //TODO since c++17 there is std::size() in <iterator> for arrays | ||
| // NTA_ASSERT(this->getNumInputs() == std::vector<UInt>(inputArray).size()); //FIXME get size of the array (T*) ? | ||
| // NTA_ASSERT(this->getNumColumns() == sizeof(*activeArray)/sizeof(UInt)); |
There was a problem hiding this comment.
How can we overcome that inputArray[] is of type T*? We need the size of the passed array.
|
|
||
| EXPECT_NO_THROW(sp.compute(inputOK.data(), true, outOK.data())); | ||
| //FIXME EXPECT_ANY does not handle the malloc fail caused here, crashes! | ||
| //! EXPECT_ANY_THROW(sp.compute(inputFail.data(), true, outOK.data())); |
There was a problem hiding this comment.
the test crashes (malloc) even though we know it'd crash and want to check for it. Is there a way how to achieve this?
3 tasks
|
Won't fix. Moved to htm-community#9 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388