Promotion automatique des modérateurs #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those libraries are not directly used in the code, and the fixed version 1.14.0 of cffi causes python environment installation issues with some Linux distributions (e.g. Archlinux as of july 23).
Remove explicit chardet package from requirements
This allows reducing the boilerplate when writing unit tests, among other things by making app contexts optional
This is made optional by flask-pytest.
This will be mandatory with flask 2.3
There is an incompatibility between flask-webtest 0.1.3 and flask 2.3 level12/flask-webtest#22
This brings a lot of helpers for testing, including form filling
This avoids to cast the variable later in the views.
This ensures the templates always know if users are connected, and avoids explicitly passing the variable in the view functions, thus reducing the code quantity. This also automatically fills the user name in the forms if they are logged in.
|
Concernant le bouton "S'identifier", il faudrait le séparer franchement au dessous du formulaire, avec ce texte devant : |
|
@klorydryk Avec les derniers changements:
|
|
Ca me paraît bien ! Attendons maintenant le retour du relecteur :) |
|
Pour information, le test sur la couverture de code échoue, mais ça n'est pas grave. Ça vient du fait qu'avec les différents réusinages j'ai réduit la quantité totale de code. |
|
Le refacto diminue le code coverage, ça n'est pas très important en vérité. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@klorydryk @nschont
Résumé
Cette PR apporte les modifications décrites dans le ticket #5, à savoir :
Quelques détails :
Questions
Pour le moment, le bouton de connexion se présente sous cette forme :
Est-ce que ça convient ? À défaut on pourrait aussi afficher un lien bleu classique avec un texte plus explicite tel que « se connecter pour modérer la salle »
cc: @LoanR
fixes: #5