Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctifs sur l'authentification des élèves #7

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

azmeuk
Copy link
Collaborator

@azmeuk azmeuk commented Jul 26, 2023

Cette PR

  • évite les crashes en cas de mauvaise configuration de l'authentification des participants au séminaire, lorsque le code tente d'accéder à leurs noms et prénoms
  • autorise la définition de variables d'environnement OIDC_SCOPES et OIDC_ATTENDEE_SCOPES pour paramétrer les champs demandés en lecture dans les profils utilisateurs à l'authentification. S'ils sont définis en tant que variables d'environnements, ils doivent prendre la forme d'une chaîne de caractère unique composée de plusieurs valeurs séparées par des virgules, par exemple : OIDC_SCOPES="openid, email, profile"

fixes #8

@azmeuk azmeuk changed the title do not raise an exception if attendee name cannot be read in the userinfo Correctifs sur l'authentification des élèves Jul 28, 2023
… userinfo

this can happen in case of OIDC provider misconfiguration, such as
wrongly configurated scopes, resulting in `given_name` and `family_name`
claims being absent from the user profile.
variables. By default if `OIDC_ATTENDEE_SCOPES` is undefined, it will
take the value of `OIDC_SCOPES`.

If defined in an environment variable, this must be a single string of
values separated by commas, like:

OIDC_SCOPES="openid, email, profile"
@nschont nschont merged commit 63ede76 into numerique-gouv:main Aug 17, 2023
2 of 5 checks passed
@azmeuk azmeuk deleted the unkown-attendee branch August 17, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration des scopes OIDC via des variables d'environnement
2 participants