Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: work around a bug in the new theme #17257

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Conversation

mattip
Copy link
Member

@mattip mattip commented Sep 5, 2020

Due to a bug in the theme, a toctree inside a section title is not shown in the left navbar. xref pydata/pydata-sphinx-theme#218. A work-around is to copy the toctree to the top of the document. This should be removed when that issue is resolved.

Note this PR only works around the issue, it does not try to clean up the perhaps unneeded links in the TOC.

@charris
Copy link
Member

charris commented Sep 7, 2020

@mattip Is this still needed?

@mattip
Copy link
Member Author

mattip commented Sep 7, 2020

Yes. Compare the left navbar in the affected page from the latest devdocs, which is missing, to the the one from this pr

@charris charris merged commit d73991e into numpy:master Sep 7, 2020
@charris
Copy link
Member

charris commented Sep 7, 2020

OK, let's get this in. Fixes upstream seem to have stalled out for the moment. Thanks Matti.

@mattip mattip deleted the theme-bug branch April 8, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants