[W6.4h][F09-B4]Zhong ZhengXin #734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-l-a
reviewed
Mar 18, 2018
|
|
||
| for(Printable p: printables) { | ||
|
|
||
| concatenatedStringResult.concat(p.getPrintableString() + " "); |
There was a problem hiding this comment.
Another way you can do this is using the StringJoiner class that java provides.
| /** | ||
| *Produces a printable string representation of the object | ||
| */ | ||
| String getPrintableString(); |
There was a problem hiding this comment.
Good job having a header comment for this method. You may want to have a header comment for the interface, as well.
| /** | ||
| * Returns a concatenated version of the printable strings of each object. | ||
| */ | ||
| String getPrintableString(Printable... printables){ |
There was a problem hiding this comment.
Ideally, this method should be used somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use interfaces [LO-Interfaces]:
Exercise: Add a Printable interface
1.Add a Printable interface
2.Add the following method (getPrintableString(Printable... printables) in a suitable place of some other class. Note how the method depends on the Interface.
"/**
*/
String getPrintableString(Printable... printables){"
3.The above method can be used to get a printable string representing a bunch of person details. For example, you should be able to call that method like this:
"//p is a Person object
return getPrintableString(p.getPhone(), p.getEmail(), p.getAddress()); "