-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Foo Jing Yi] iP #449
Open
foojingyi
wants to merge
107
commits into
nus-cs2103-AY2021S1:master
Choose a base branch
from
foojingyi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Foo Jing Yi] iP #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Message objects
…tialised with the whole of the next line of user input and not with each word of the line as separate objects
…ons to replies to LIST command
…rt of Task's string representation and not added in Message's reply() method
… commands, added TODO, DEADLINE and EVENT to Command types
…eply() for NOT_FOUND command
…le exceptions as named in the file names
…nputs with no commands and 2. todo/deadline/event commands with no description, are handled as exceptions
…m "done" and "delete" commands
…WrongItemIndexException
# Conflicts: (Resolved) # src/main/java/duke/Storage.java # src/main/java/duke/TaskList.java
Improve Code Quality
* reduce arrowhead code by abstracting methods out * add new exceptions * change exception names for readibility
Searches for task using the "Find" command can now include multiple keywords and can tasks can be found even if only matching partially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.