[Han Jiyao] iP #303

HanJiyao · 2022-01-30T00:37:07Z

Duke Chat

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

hsiaojietng

LGTM. If you're able to encapsulate the behaviour of all the actions of Duke then it would be better

hsiaojietng · 2022-01-31T05:14:23Z

src/main/java/Deadline.java

+    @Override
+    public String toString() {
+        return "["+Type.D+"]" + super.toString() + " (by: " + by + ")";
+    }


Well done on the naming of variables, they are easily read!

hsiaojietng · 2022-01-31T05:16:12Z

src/main/java/Duke.java

+
+                    case "deadline":
+                        StringBuilder deadline = new StringBuilder();
+                        StringBuilder deadlineBy = new StringBuilder();


Maybe can encapsulate this functionality in another class if you want

hsiaojietng · 2022-01-31T05:16:46Z

src/main/java/Event.java

+        this.at = at.trim();
+    }
+
+    public Event(String task, boolean done) {


Easy to read!

9teMare

Overall good job 🙂!
Just a few points to mention:

OOP practices can be implemented better
Coding standard should be followed consistently
Seems like you are a little bit behind schedule, looking forward to your GUI implementation!

9teMare · 2022-02-04T17:42:32Z

src/main/java/command/AddDeadlineCommand.java

+    }
+
+    public void execute(TaskList tasks, Ui ui, Storage storage) {
+        tasks.add(new Deadline(newDeadline.getTask(), newDeadline.getDate()));


I like how you use getter method to keep fields in Deadline class private. Good job 👍!

9teMare · 2022-02-04T17:44:03Z

src/main/java/command/AddDeadlineCommand.java

+    public void execute(TaskList tasks, Ui ui, Storage storage) {
+        tasks.add(new Deadline(newDeadline.getTask(), newDeadline.getDate()));
+        storage.saveTaskList(tasks);
+        ui.showMessage("Got it. I've added this task: \n        "


Extra blank spaces after the new line character is a little bit misleading, maybe can move these blank spaces into the next line.

9teMare · 2022-02-04T17:45:38Z

src/main/java/command/AddDeadlineCommand.java

+        tasks.add(new Deadline(newDeadline.getTask(), newDeadline.getDate()));
+        storage.saveTaskList(tasks);
+        ui.showMessage("Got it. I've added this task: \n        "
+                + tasks.getByIndex(tasks.getSize() - 1) + "\n    Now you have " + tasks.getSize() + " tasks in the list.");


Not sure if this line of code is too long for our coding standard, but generally try to break up a long line of code like this.

9teMare · 2022-02-04T17:54:21Z

src/main/java/command/ErrorCommand.java

+import task.TaskList;
+import ui.Ui;
+
+public class ErrorCommand extends Command {


I love your implementation of having an abstract class Command and various other commands that extend it, however, personally I do not think an ErrorCommand is considered as a Command, because if you think about it, it is not like the user wants to input something intentionally that triggers this. The code works perfectly fine, it's just that why not throw exception directly when parsing the user input in the first place, instead of having recognized that the user input something invalid but still parse it to a Command?

9teMare · 2022-02-04T17:55:21Z

src/main/java/command/ExitCommand.java

+    @Override public void execute(TaskList tasks, Ui ui, Storage storage) {
+        ui.showExitMessage();
+    }
+
+    @Override public boolean isExit() {
+        return true;
+    }


The @Override tag should occupy its own line.

9teMare · 2022-02-04T18:00:09Z

src/main/java/parser/Parser.java

+import command.ExitCommand;
+import command.MarkCommand;
+import command.ListCommand;
+import data.DukeException;


Not sure if this line follows the import order in checkStyle.

9teMare · 2022-02-04T18:06:13Z

src/main/java/storage/Storage.java

+                        }
+                        break;
+                    case "D":
+                        Deadline newDeadline = new Deadline(input.get(2).trim(), LocalDate.parse(input.get(3).trim(), formatter));


Sufficient comment here can probably improve the readability by a lot.

9teMare · 2022-02-04T18:12:46Z

src/main/java/task/Deadline.java

+import java.time.format.DateTimeFormatter;
+
+public class Deadline extends Task {
+    protected LocalDate by;


private should be a better accesser here than protected because there are no other classes extending from Deadline, therefore, the only object that will access this field is of type Deadline. Declaring this field as final should also be a good practice because the time should not be changed after new() an object.

9teMare · 2022-02-04T18:14:55Z

src/main/java/task/Deadline.java

+
+    @Override
+    public String saveData() {
+        int done = super.done? 1 : 0;


Declaring this as boolean isDone might be better.

9teMare · 2022-02-04T18:20:31Z

src/main/java/task/Task.java

+    public Task mark() {
+        return new Task(task, true);
+    }
+
+    public Task unmark() {
+        return new Task(task, false);
+    }


Not too sure about the rationale behind the need to new() an object, (same for Deadline Event and Todo), why not just simply set the done field as true or false, all the children of Task share the same behaviour and they can just access mark() and unmark() straight away.

# Conflicts: # duke/data/TaskList.txt

There is a method that previous used as textUI to convert cli command into console output. This method is never used as GUI has implemented. Removing all these unused code improves the code quality. As a step towards such unification, let's remove those unused code blocks in their respective classes. Doing so will make the code easier to understand.

Duke: getResponse() add assertion Parser: parse() add assertion Storage: load() add assertion Ui: showMessage() add assertion MainWindow: add DukeException Add assertion failure indicates possible bug Use assert feature aim to document important assumptions that should hold at various points in the code. Let's update the methods with assertions. Using assertion is preferable.

Improve code quality

Add assertion

There is a name error from prepareAddTodo() to prepareAddToDo(). Fixing this name error will resolve the application cannot run. Let's update the method name inside the Parse class.

Mark an item as a high normal low priority

Branch c priority sort

damithc and others added 9 commits July 29, 2021 20:30

Add Gradle support

d839859

Greet, Echo, Exit

1c58c46

Add, List

c9eb14c

Mark as Done

155a643

ToDos, Events, Deadlines

4957053

Automated Text UI Testing

f2253e1

Handle Errors

3838a18

Delete

b597f58

Use Enums

487f743

hsiaojietng reviewed Jan 31, 2022

View reviewed changes

HanJiyao added 12 commits February 1, 2022 19:32

Configure workflow

56225e7

Save

48e2f6d

Dates and Times

4d1eb80

Merge Dates and Times

7091195

Mark correction

8b9cda8

Use More OOP

2e9dc51

Organize into Packages

1c8552d

Merge remote-tracking branch 'origin/add-gradle-support'

f5a3b70

Create New Gradle and put in source

eff6e71

Merge branch 'branch-A-Gradle'

6d47139

Add JUnit Tests

c56753c

Create a JAR File

08c07f8

9teMare reviewed Feb 4, 2022

View reviewed changes

HanJiyao added 7 commits February 5, 2022 02:35

Find

dce93d4

Add JavaDoc comments

81fc655

Tweak the code to comply with a coding standard

101e5d5

Merge branch 'branch-A-CodingStandard'

434b8e2

Merge branch 'branch-Level-9'

4bdbade

# Conflicts: # duke/data/TaskList.txt

Use CheckStyle

d10fbdf

update find

5049a11

HanJiyao and others added 30 commits February 11, 2022 01:18

Improve code quality

2421531

Merge pull request #1 from HanJiyao/branch-A-CodeQuality

563adc5

Improve code quality

Merge branch 'master' into branch-A-Assertions

a5c14ef

Merge pull request #2 from HanJiyao/branch-A-Assertions

be2f68d

Add assertion

Resolve name error by merging

b56632e

There is a name error from prepareAddTodo() to prepareAddToDo(). Fixing this name error will resolve the application cannot run. Let's update the method name inside the Parse class.

Clear up more code quality

29c34e9

Change exit behavior

040bf3d

Import checkstyle config

0524042

Improve code quality change header comments and variable name

6c19c88

Use Streams

807c50c

Set up CI

f358128

Set up CI

d737951

Provide a way to attach priorities to items

77b7f78

Mark an item as a high normal low priority

Sort items managed by app

e29df41

Modify runtest

dd5f585

Modify ui-test

34d91f6

Merge pull request #4 from HanJiyao/branch-C-PrioritySort

e3dbb49

Branch c priority sort

Merge pull request #4 from HanJiyao/branch-C-PrioritySort

ed249d5

Branch c priority sort

Merge remote-tracking branch 'origin/master'

dbfdf37

Trail commitO

2126abb

Clear up format

6cf8715

Create gradle.yml

c55e9a3

Edit runtest

c2b7e71

Merge remote-tracking branch 'origin/master'

dff2e82

Remove text-ui-test as no longer needed

11f3ceb

Better GUI

deba367

Add a User Guide

dc4be77

Bug fix date parser

48c91bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Han Jiyao] iP #303

[Han Jiyao] iP #303

HanJiyao commented Jan 30, 2022 •

edited

Loading

hsiaojietng left a comment

hsiaojietng Jan 31, 2022

hsiaojietng Jan 31, 2022

hsiaojietng Jan 31, 2022

9teMare left a comment

9teMare Feb 4, 2022

9teMare Feb 4, 2022

9teMare Feb 4, 2022

9teMare Feb 4, 2022

9teMare Feb 4, 2022

9teMare Feb 4, 2022

9teMare Feb 4, 2022

9teMare Feb 4, 2022

9teMare Feb 4, 2022

9teMare Feb 4, 2022

[Han Jiyao] iP #303

Are you sure you want to change the base?

[Han Jiyao] iP #303

Conversation

HanJiyao commented Jan 30, 2022 • edited Loading

Duke Chat

Features:

hsiaojietng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

9teMare left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HanJiyao commented Jan 30, 2022 •

edited

Loading