-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tanjieling0 patch 1 #299
Closed
tanjieling0
wants to merge
635
commits into
nus-cs2103-AY2324S2:master
from
AY2324S2-CS2103T-F12-1:tanjieling0-patch-1
Closed
Tanjieling0 patch 1 #299
tanjieling0
wants to merge
635
commits into
nus-cs2103-AY2324S2:master
from
AY2324S2-CS2103T-F12-1:tanjieling0-patch-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: Edit command allows user to edit the remarks of person. No reason for there to be 2 commands carrying out the same function.
UI Changes: Add Destructive warnings to improve UX
Change Model#setPerson to enforce id not modified
Refactor code
Remove remark command
Refactor statestorage under storage
Add stack filters feature
Update Export CSV to export current view
Update info and warning boxes to use markbind box
Dg improvements v1.4
Update index.md
Developer Guide: Update the Person Role Implementation
Edit ToC hyperlink and add line break
Add planned enhancements
Add page break to User Guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.