Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the yadm module. #975

Merged
merged 18 commits into from
Oct 17, 2024
Merged

Rewrite the yadm module. #975

merged 18 commits into from
Oct 17, 2024

Conversation

louiss0
Copy link
Contributor

@louiss0 louiss0 commented Oct 17, 2024

I'm here to fix the mistake that I made with the Yadm module.

I removed completions in favor of just scripts.
I also added a way to install yadm as well.

@fdncred
Copy link
Collaborator

fdncred commented Oct 17, 2024

We really need to get our formatter done because the formatting isn't great in this file. Lots of extra spaces and lines all over the place. I won't block on formatting this time, but it would be nice if it were better looking.

@louiss0
Copy link
Contributor Author

louiss0 commented Oct 17, 2024

We really need to get our formatter done because the formatting isn't great in this file. Lots of extra spaces and lines all over the place. I won't block on formatting this time, but it would be nice if it were better looking.

I wish I could help with that. Disciplined formatting is harder than you think.

@fdncred fdncred merged commit 04c7078 into nushell:main Oct 17, 2024
1 check passed
@fdncred
Copy link
Collaborator

fdncred commented Oct 17, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants