Maruyama #33
Open
Maruyama #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100本ノック第一章00.
100本ノック第1章01.です
100本ノック第1章03です。
takegue
reviewed
Nov 26, 2016
| # -*- coding: utf-8 -*- | ||
| line_number = 0 | ||
| with open('input.txt') as input_file: | ||
| for line in input_file: |
There was a problem hiding this comment.
line_numberを使うよりもenumerateを使う
for num, line in enumerate(input_file):
# hogehoge
takegue
reviewed
Nov 26, 2016
| @@ -0,0 +1,6 @@ | |||
| # -*- coding: utf-8 -*- | |||
| with open('input.txt') as input_file: | |||
There was a problem hiding this comment.
ネストが多くなるのは、できるだけ避ける
with構文の場合は, 複数の構文も下の様に書ける
with open('file1') as fp1, open('file2') as fp2:
#hogehoge
takegue
reviewed
Nov 26, 2016
| with open('col1.txt', 'w') as output1_file: | ||
| with open('col2.txt', 'w') as output2_file: | ||
| for line in iter(input_file.readlines()): | ||
| output1_file.writelines(line.split('\t')[0]+'\n') |
There was a problem hiding this comment.
3個以上になると \を使って改行しないといけないので ならcontextlib.ExitStackが個人的にはオススメ
ExitStack
|
あ、あとPR先をmaruyama branchに変えておいてくださいお願いします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
100本ノック11修正及び13