-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Pipeline left in an inconsistent state when the init function passed to make_segment throws #360
Labels
bug
Something isn't working
Comments
dagardner-nv
added a commit
to dagardner-nv/Morpheus
that referenced
this issue
Aug 2, 2023
3 tasks
dagardner-nv
added a commit
to dagardner-nv/MRC
that referenced
this issue
Aug 2, 2023
3 tasks
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this issue
Aug 30, 2023
* Fixes a memory leak #1114 by releasing reference to MRC Pipeline & Executor on stop. * Numerous pylint fixes for `morpheus/pipeline/pipeline.py` * Skip `tests/test_multi_segment.py::test_multi_segment_bad_data_type` due to nv-morpheus/MRC#360 fixes #1114 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Christopher Harris (https://github.com/cwharris) - Michael Demoret (https://github.com/mdemoret-nv) URL: #1115
dagardner-nv
added a commit
to dagardner-nv/MRC
that referenced
this issue
Sep 26, 2023
3 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
Sep 28, 2023
* Prevents `check_active_connection` from mistakenly returning true for a holder where `init_owned_edge` has been called but neither the `init_connected_edge method` or the `add_connector` method have not been called. Relates to issue #360 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #402
3 tasks
3 tasks
This was referenced Jan 17, 2024
Closed
dagardner-nv
added a commit
to dagardner-nv/MRC
that referenced
this issue
Jan 22, 2024
…n loaded and added to the segment [no ci]
dagardner-nv
added a commit
to dagardner-nv/MRC
that referenced
this issue
Jan 22, 2024
…n on MRC issue nv-morpheus#360 [no ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
23.11
Which installation method(s) does this occur on?
Source
Describe the bug.
This occurs with Morpheus' test_multi_segment_bad_data_type test which intentionally builds a multi-segment pipeline where one of the segments fails a pre-flight check and raises/throws in the init method passed to the
mrc::pymrc::Pipeline::make_segment
method.When the pipeline goes out of scope we then get a failed assert in
edge_holder
:Minimum reproducible example
Note:
Currently Morpheus has a circular reference issue such that the MRC executor is never destroyed, fixing this issue uncovered this issue.
Full env printout
No response
Other/Misc.
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: