Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break circular reference issue causing a memory leak #1115

Merged
merged 28 commits into from
Aug 30, 2023
Merged

Break circular reference issue causing a memory leak #1115

merged 28 commits into from
Aug 30, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 2, 2023 •
edited
Loading

Description

fixes #1114

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner August 2, 2023 16:55
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review labels Aug 2, 2023
cwharris
cwharris approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments

morpheus/pipeline/pipeline.py Outdated Show resolved Hide resolved
tests/test_multi_segment.py Show resolved Hide resolved
@dagardner-nv dagardner-nv added the DO NOT MERGE PR should not be merged; see PR for details label Aug 14, 2023
@dagardner-nv dagardner-nv removed the DO NOT MERGE PR should not be merged; see PR for details label Aug 15, 2023
@dagardner-nv dagardner-nv added the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Aug 16, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 18, 2023 15:02
@dagardner-nv dagardner-nv removed the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Aug 18, 2023
mdemoret-nv
mdemoret-nv approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Merge once comments are resolved. I think we can remove some of the GC tests since they can be executed better in MRC

tests/conftest.py Show resolved Hide resolved
tests/test_gc_tls.py Outdated Show resolved Hide resolved
tests/test_multi_segment.py Show resolved Hide resolved
tests/test_pipe.py Outdated Show resolved Hide resolved
tests/test_pipe.py Outdated Show resolved Hide resolved
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4ae80d0 into nv-morpheus:branch-23.11 Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

@cwharris cwharris cwharris approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Stage destructors not called
3 participants
@dagardner-nv @cwharris @mdemoret-nv