Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "or later" from copying.txt #17200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gerald-hartig
Copy link
Collaborator

@gerald-hartig gerald-hartig commented Sep 22, 2024

Link to issue number:

Revert #16830

Summary of the issue:

Inadvertently merged PR before licence clarification was fully addressed

Description of user facing changes

Revert "GPL-2 or later" to "GPL-2"

@coderabbitai summary

@seanbudd seanbudd added blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. blocked labels Sep 24, 2024
@seanbudd seanbudd added the release/blocking this issue blocks the milestone release label Oct 21, 2024
@seanbudd seanbudd added this to the 2025.1 milestone Oct 21, 2024
@gerald-hartig gerald-hartig marked this pull request as ready for review October 21, 2024 23:39
@gerald-hartig gerald-hartig requested a review from a team as a code owner October 21, 2024 23:39
@seanbudd
Copy link
Member

My concern with merging this as-is, in #16830 we declared a bunch of apache licenses as compatible in the license check, but if we revert "or later" these changes should probably be reverted too.

@seanbudd
Copy link
Member

Other updates that may need to happen:

  • the "license" section in pyproject.toml
  • the copyright headers file (however I think we can declare new files as GPLv2 or later with no issue)

@ethindp
Copy link

ethindp commented Oct 24, 2024

Look, this PR and the older license PR should've never been merged to begin with. Revert the old PR and then re-open it. Right now this project is actively violating the GPL because the right way to do this is to ask (every) contributor, past and present, and to get their confirmation before re-licensing.

@gerald-hartig
Copy link
Collaborator Author

@ethindp We're currently speaking to our legal team and the FSF to get clarity on what is required and the best way to proceed. This PR is on the 2025.1 milestone which means that if this issue is not resolved by the time our next release comes out, the addition of the lifeboat clause will be reverted. The 2024.4 release also does not contain the lifeboat clause.

@ethindp
Copy link

ethindp commented Oct 24, 2024

@gerald-hartig Ah okay. I do believe I am correct on this matter, unless the FSF explains otherwise. I would recommend you just revert the mistaken PR and go from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. blocked release/blocking this issue blocks the milestone release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants