Add ability to read math in PDF documents

source/NVDAObjects/IAccessible/adobeAcrobat.py

@@ -143,29 +143,36 @@ def _getNodeMathMl(self, node):
 		yield "</%s>" % tag
 
 	def _get_mathMl(self) -> str:
+		"""Return the MathML associated with a Formula tag"""
 		if self.pdDomNode is None:
 			log.debugWarning("_get_mathMl: self.pdDomNode is None!")
 			raise LookupError
-		# There could be other stuff before the math element. Ug.
 		mathMl = self.pdDomNode.GetValue()
-		log.debug(
-			f'\n_get_mathMl: math recognized: {mathMl.startswith("<math")}, child count={self.pdDomNode.GetChildCount()}',
-			f"\nname={self.pdDomNode.GetName()}\nvalue={self.pdDomNode.GetValue()}",
-		)
+		if log.isEnabledFor(log.DEBUG):
+			log.debug(
+				(
+					f"_get_mathMl: math recognized: {mathMl.startswith('<math')}, "
+					f"child count={self.pdDomNode.GetChildCount()},"
+					f"\n  name='{self.pdDomNode.GetName()}', value='{mathMl}'"
+				),
+			)
 		# this test and the replacement doesn't work if someone uses a namespace tag (which they shouldn't, but..)
 		if mathMl.startswith("<math"):
 			return mathMl.replace('xmlns:mml="http://www.w3.org/1998/Math/MathML"', "")
+		# Alternative for tagging: all the sub expressions are tagged -- gather up the MathML
 		for childNum in range(self.pdDomNode.GetChildCount()):
 			try:
 				child = self.pdDomNode.GetChild(childNum).QueryInterface(IPDDomElement)
 			except COMError:
 				log.debugWarning(f"COMError trying to get childNum={childNum}")
 				continue
-			log.debug(f"\tget_mathMl: tag={child.GetTagName()}")
+			if log.isEnabledFor(log.DEBUG):
+				log.debug(f"\tget_mathMl: tag={child.GetTagName()}")
 			if child.GetTagName() == "math":
 				return "".join(self._getNodeMathMl(child))
-		# fall back to return the contents, which is hopefully to be alt text
-		log.debug("_get_mathMl: didn't find MathML -- returning value as mtext")
+		# fall back to return the contents, which is hopefully alt text
+		if log.isEnabledFor(log.DEBUG):
+			log.debug("_get_mathMl: didn't find MathML -- returning value as mtext")
 		return f"<math><mtext>{self.pdDomNode.GetValue()}</mtext></math>"
 
 

user_docs/en/changes.md

@@ -7,11 +7,16 @@
 ### New Features
 
 * Support for math in PDFs has been added.
-This works for formulas that have MathML in an Associated File.
-Tagged formulas are supported in newer versions of TeX/LaTeX (#9288, @NSoiffer)
+This works for Formulas with associated MathML mark-up, such as some files generated by newer versions of TeX/LaTeX.
+Currently this is only supported in Foxit Reader & Foxit Editor. (#9288, @NSoiffer)
 * The volume of other applications can be adjusted by `NVDA+alt+pageUp` and `NVDA+alt+pageDown`. In order to use this feature, application volume adjuster needs to be enabled in Audio pane of NVDA settings. (#16052, @mltony)
 * Added command to mute or unmute all other applications, assigned to `NVDA+alt+delete`.
 In order to use this feature, the application volume adjuster needs to be enabled in the Audio category of NVDA settings. (#16052, @mltony)
+* Commands to adjust the volume of other applications besides NVDA have been added.
+To use this feature, "allow NVDA to control the volume of other applications" must be enabled in the audio settings panel. (#16052, @mltony, @codeofdusk)
+  * `NVDA+alt+pageUp`: Increase the volume of all other applications.
+  * `NVDA+alt+pageDown`: Decrease the volume of all other applications.
+  * `NVDA+alt+delete`: Mute the volume of all other applications.
 * When editing in Microsoft PowerPoint text boxes, you can now move per sentence with `alt+upArrow`/`alt+downArrow`. (#17015, @LeonarddeR)
 * In Mozilla Firefox, NVDA will report the highlighted text when a URL containing a text fragment is visited. (#16910, @jcsteh)
 * NVDA can now report when a link destination points to the current page. (#141, @LeonarddeR, @nvdaes)