Fix appVolumeAdjuster when state is default #17321
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrilleB79
reviewed
Oct 24, 2024
| @@ -88,7 +89,7 @@ def _updateAppsVolumeImpl( | |||
| state: AppsVolumeAdjusterFlag, | |||
| ): | |||
| global _activeCallback | |||
| if state == AppsVolumeAdjusterFlag.DISABLED: | |||
| if state in [AppsVolumeAdjusterFlag.DEFAULT, AppsVolumeAdjusterFlag.DISABLED]: | |||
There was a problem hiding this comment.
If one day, the default state becomes "enabled" in the config spec, this statement will not work anymore. I guess that feature flags implement equality management so that comparing with default actually compares to its current value. It would be interesting to check here and to investigate why this equality management is not automatic here.
There was a problem hiding this comment.
Yeah I was also under impression that it should happen automatically. Hence this bug. But it's not likely appVolumeAdjuster will ever be enabled by default - there is a strong opposition to that from some folks here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#17300
Summary of the issue:
When AppVolumeAdjuster state is set to default, pressing OK or Apply button in settings sets the volume of all apps to 100%.
Description of user facing changes
Bug fixed. Now when AppVolumeAdjuster state is set to default, application volumes are not changed.
Description of development approach
Checking for state==default in the right place.
Testing strategy:
Manually tested use case from the issue above.
Known issues with pull request:
N/A
Code Review Checklist:
@coderabbitai summary