Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the show_symlink option to finder #334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aadi58002
Copy link

Addresses the issue #300

And also the reopen issue for #323 ( which was closed by mistake )

Copy link
Collaborator

@jamestrew jamestrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're on the right track.
Besides the changes I mentioned, we also need to tackle the <cr> behavior when show_symlinks = true and follow_symlinks = false.

Right now, the open_dir action already calls fs_realpath so it follows symlinks regardless of the follow_symlinks option. I think this can be considered a bug.
Probably want to take that out. We can dictate which path (real or symlink) <cr> will act on here:

if k == "path" then
return t.value
end
by setting this to realpath if follow_symlinks = true or keep it t.value.

Also CI is failing. I think you just need to run stylua.

doc/telescope-file-browser.txt Outdated Show resolved Hide resolved
lua/telescope/_extensions/file_browser/make_entry.lua Outdated Show resolved Hide resolved
lua/telescope/_extensions/file_browser/make_entry.lua Outdated Show resolved Hide resolved
lua/telescope/_extensions/file_browser/make_entry.lua Outdated Show resolved Hide resolved
@gmankab
Copy link

gmankab commented Oct 22, 2024

this really should be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants