Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for eot, otf, woff, and update mime type for woff2 #361

Merged

Conversation

david-poindexter
Copy link
Member

Related to Issue

Fixes #359

Description

With the wide support of woff2 in modern browsers, there is no need to continue using woff. While I was at it, I went ahead and removed eot and otf support as well. woff2 alone is sufficient for most projects but depending on your site user base, you may want to add back in woff support (especially if Internet Explorer is still in use, despite it's support end-of-life by Microsoft).

How Has This Been Tested?

Local dev env

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@david-poindexter david-poindexter added the enhancement New feature or request label Dec 29, 2023
@david-poindexter david-poindexter added this to the 3.1.0 milestone Dec 29, 2023
@david-poindexter david-poindexter self-assigned this Dec 29, 2023
Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@david-poindexter david-poindexter merged commit 6fef6cf into nvisionative:develop Dec 29, 2023
3 checks passed
@david-poindexter david-poindexter deleted the remove-woff-support branch December 29, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove woff font support in favor of woff2 only
1 participant