Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Join/Leave notification doesn't work correctly #271

Open
vavavr00m opened this issue Jun 4, 2024 · 2 comments
Open

[BUG] Join/Leave notification doesn't work correctly #271

vavavr00m opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@vavavr00m
Copy link

vavavr00m commented Jun 4, 2024

Describe the issue
Join/Leave notification doesn't send a message to Discord.

EDIT: I just logged on today and it says I died. It also happened to another player. I asked them how they died in the game after joining the server and I was informed the character is still alive. It's very inconsistent. Sometimes it does work, other times it doesn't and then it does and then incorrectly says someone died when it should be joined. With the leave notification, sometimes it is correctly working and then it stops working.

Expected behavior
When a player joins or leaves (Log out button, Quit button, Close button, Network error, Desync, Crash), DiscordConnector should send a correct notication in Discord that the player did.

Screenshots
If I have truly died, there would have been a DarwinArwards death notification prior the DiscordConnector death notification but there was nothing in this screenshot, therefore, this was supposed to be the join notification sent by DiscordConnector as death:
image

Configuration

{"Config.Main":{"discord":{"webhook":"unset","webhookEvents":"ALL","webhook2":"unset","webhook2Events":"ALL","logDebugMessages":"False","fancierMessages":"False","ignoredPlayers":"","ignoredPlayersRegex":""},"collectStatsEnabled":"True","sendPositionsEnabled":"True","announcePlayerFirsts":"True","playerLookupPreference":"PlayerId"},"Config.Messages":{"Messages.Server":{"launchMessage":"Server is starting up.","startMessage":"Server has started!","stopMessage":"Server is stopping.","shutdownMessage":"Server has stopped!","savedMessage":"The world has been saved.""serverNewDayMessage":"Day Number %DAY_NUMBER%"},"Messages.Player":{"joinMessage":"%PLAYER_NAME% has joined.","deathMessage":"%PLAYER_NAME% has died.","leaveMessage":"%PLAYER_NAME% has left.","pingMessage":"%PLAYER_NAME% pings the map.","shoutMessage":"%PLAYER_NAME% shouts **%SHOUT%**."},"Messages.PlayerFirsts":{"joinMessage":"%PLAYER_NAME% has joined.","deathMessage":"%PLAYER_NAME% has died.","leaveMessage":"%PLAYER_NAME% has left.","pingMessage":"%PLAYER_NAME% pings the map.","shoutMessage":"%PLAYER_NAME% shouts **%SHOUT%**."},"Messages.Events":{"eventStartMessage":"**Event**: %EVENT_MSG%","eventPausedMessage":"**Event**: %EVENT_END_MSG% — for now! (Currently paused due to no players in the event area.)","eventResumedMessage":"**Event**: %EVENT_START_MSG%","eventStopMessage":"**Event**: %EVENT_MSG%"},"Messages.LeaderBoards":{"leaderBoardTopPlayersMessage":"Top %N% Player Leader Boards:","leaderBoardBottomPlayersMessage":"Bottom %N% Player Leader Boards:","leaderBoardHighestPlayerMessage":"Top Performer","leaderBoardLowestPlayerMessage":"Bottom Performer"}},"Config.Toggles":{"Toggles.Messages":{"launchMessageEnabled":"True","loadedMessageEnabled":"True","stopMessageEnabled":"True","shutdownMessageEnabled":"True","chatShoutEnabled":"True","chatPingEnabled":"True","playerJoinEnabled":"True","playerLeaveEnabled":"True","playerDeathEnabled":"True","eventStartEnabled":"True","eventPausedEnabled":"True","eventStoppedEnabled":"True","eventResumedEnabled":"True","chatShoutAllCaps":"False""newDayNumberToggle":"True"},"Toggles.Position":{"chatShoutPosEnabled":"False","chatPingPosEnabled":"True","playerJoinPosEnabled":"False","playerLeavePosEnabled":"False","playerDeathPosEnabled":"True","eventStartPosEnabled":"True","eventStopPosEnabled":"True","eventPausedPosEnabled":"True","eventResumedPosEnabled":"True"},"Toggles.Stats":{"statsDeathEnabled":"True","statsJoinEnabled":"True","statsLeaveEnabled":"True","statsPingEnabled":"True","statsShoutEnabled":"True"},"Toggles.PlayerFirsts":{"announceFirstDeathEnabled":"True","announceFirstJoinEnabled":"True","announceFirstLeaveEnabled":"False","announceFirstPingEnabled":"False","announceFirstShoutEnabled":"False"},"Toggles.DebugMessages":{"debugEveryPlayerPosCheck":"False","debugEveryEventCheck":"False","debugEventChanges":"False","debugDatabaseMethods":"False","debugHttpRequestResponses":"False"}},"Config.Variables":{"User-Defined":{"userVar":"","userVar1":"","userVar2":"","userVar3":"","userVar4":"","userVar5":"","userVar6":"","userVar7":"","userVar8":"","userVar9":""},"Dynamic-Configured":{"posVarFormat":"%X%, %Y%, %Z%","appendedPosFormat":"Coords: (%POS%)"}},"Config.LeaderBoard":{"leaderBoard1":{"enabled":"False","periodInMinutes":600,"displayedHeading":"LeaderBoard.1 Statistic Leader Board","type":"Descending","timeRange":"AllTime","numberListings":3,"deaths":"True","sessions":"False","shouts":"False","pings":"False","timeOnline":"False"},"leaderBoard2":{"enabled":"False","periodInMinutes":600,"displayedHeading":"LeaderBoard.2 Statistic Leader Board","type":"Descending","timeRange":"AllTime","numberListings":3,"deaths":"True","sessions":"False","shouts":"False","pings":"False","timeOnline":"False"},"leaderBoard3":{"enabled":"False","periodInMinutes":600,"displayedHeading":"LeaderBoard.3 Statistic Leader Board","type":"Descending","timeRange":"AllTime","numberListings":3,"deaths":"True","sessions":"False","shouts":"False","pings":"False","timeOnline":"False"},"leaderBoard4":{"enabled":"False","periodInMinutes":600,"displayedHeading":"LeaderBoard.4 Statistic Leader Board","type":"Descending","timeRange":"AllTime","numberListings":3,"deaths":"True","sessions":"False","shouts":"False","pings":"False","timeOnline":"False"},"leaderBoard5":{"enabled":"False","periodInMinutes":600,"displayedHeading":"LeaderBoard.5 Statistic Leader Board","type":"Descending","timeRange":"AllTime","numberListings":3,"deaths":"True","sessions":"False","shouts":"False","pings":"False","timeOnline":"False"},"activePlayersAnnouncement":{"enabled":"False","periodInMinutes":360,"includeCurrentlyOnline":"True","includePlayersToday":"True","includePlayersPastWeek":"True","includePlayersAllTime":"True"}}}

Server Environment
Home dedicated server on Windows 11 Pro.

Installed Mods
The only mods that have been enabled to send a message via Discord webhook are:
DarwinAwards
JoinCodeSender
If a complete list of mods is needed, please let me know.

Additional context
Ashlands update. Day number, first login, first death, death w/ coords, shouts, world save seem to work fine. That's all I have so far. After adding the coords to the Join/Leave notification and then restarting the server, it worked (2:54 am, logged in), and then it didn't (logged out at around 4:52 am, no Discord message from DiscordConnector).

Here's the client log:

[Info   : Unity Log] Am I Host? False
[Info   : Unity Log] 06/05/2024 04:52:57: Available space to current user: 78191620096. Saving is blocked if below: 209845376 bytes. Warnings are given if below: 419690752

[Info   : Unity Log] Am I Host? False
[Info   : Unity Log] 06/05/2024 04:52:57: Game - OnApplicationQuit

[Info   : Unity Log] Am I Host? False
[Info   : Unity Log] 06/05/2024 04:52:57: Available space to current user: 78191620096. Saving is blocked if below: 209845376 bytes. Warnings are given if below: 419690752

[Info   : Unity Log] 06/05/2024 04:52:57: Shutting down

[Info   : Unity Log] 06/05/2024 04:52:57: Minimap: compressed mapData 8398910 => 21401 bytes

[Info   : Unity Log] 06/05/2024 04:52:57: Cloud Save: 64943 bytes. /characters/PlayerName.fch.new

[Info   : Unity Log] 06/05/2024 04:52:57: Steam writing file chunks 1 / 1, (64943 bytes)

[Info   : Unity Log] 06/05/2024 04:52:57: Steam Cloud Move: 65088 bytes. /characters/valentina.fch -> /characters/PlayerName.fch.old

[Info   : Unity Log] 06/05/2024 04:52:57: Steam writing file chunks 1 / 1, (65088 bytes)

[Info   : Unity Log] 06/05/2024 04:52:57: Steam Cloud Move: 64943 bytes. /characters/PlayerName.fch.new -> /characters/PlayerName.fch

[Info   : Unity Log] 06/05/2024 04:52:57: Steam writing file chunks 1 / 1, (64943 bytes)

[Info   : Unity Log] 06/05/2024 04:52:57: Considering autobackup. World time: 2954.92, short time: 7200, long time: 43200, backup count: 4

[Info   : Unity Log] 06/05/2024 04:52:57: No autobackup needed yet...

[Info   : Unity Log] Am I Host? False
[Info   : Unity Log] 06/05/2024 04:52:57: ZNet Shutdown

[Info   : Unity Log] 06/05/2024 04:52:57: Unloading unused assets

[Info   : Unity Log] 06/05/2024 04:52:57: Sending disconnect msg

[Info   : Unity Log] 06/05/2024 04:52:57: Sent to playfab/****************

[Info   : Unity Log] 06/05/2024 04:52:57: Released session ticket

[Info   : Unity Log] ZPlayFabMatchmaking::UnregisterServer - unregistering server now. State: Uninitialized
[Info   : Unity Log] ZPlayFabSocket::Dispose. State: CONNECTED
[Info   : Unity Log] ZPlayFabSocket::Dispose. leave lobby. LobbyId: (********-****-****-****-************.*-********)
[Info   : Unity Log] ZPlayFabSocket::Dispose. State: CLOSED
[Info   : Unity Log] 06/05/2024 04:52:58: Stopping build thread

Additional context
Screenshot and log are from different times since I wasn't able to capture a screenshot when the issue was initially raised.

@nwesterhausen nwesterhausen added the bug Something isn't working label Jun 4, 2024
@vavavr00m vavavr00m changed the title [BUG] Join/Leave notification doesn't work [BUG] Join/Leave notification doesn't work correctly Jun 7, 2024
@Rutes
Copy link

Rutes commented Jun 7, 2024

I'm also getting this, only occasionally, and it seems only for login. It will display a death message instead of login.

@upthevale
Copy link

We are also getting this issue.

Sometimes when a player logs in they get a death message which also adds to the death leaderboard.

We have login notifications turned off

We have no other mods installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants