Django5 #179
Django5 #179
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 81.75% 81.75%
=======================================
Files 33 33
Lines 2220 2220
=======================================
Hits 1815 1815
Misses 405 405 ☔ View full report in Codecov by Sentry. |
| @@ -222,7 +222,7 @@ def import_xls(cls, filename, user, import_params, log=None, import_results=None | |||
| naive_timezone = ( | |||
| zoneinfo.ZoneInfo(import_params["timezone"]) | |||
| if import_params and "timezone" in import_params | |||
| else timezone.utc | |||
There was a problem hiding this comment.
I'm confused.. isn't timezone.utc fine to use? I think we just need to set USE_DEPRECATED_PYTZ = False
There was a problem hiding this comment.
That was an alias to datetime.timezone.utc and that is removed in django 5.0
There was a problem hiding this comment.
USE_DEPRECATED_PYTZ is removed as well
There was a problem hiding this comment.
Arrghh all this time I've been replacing pytz.UTC with django.utils.timezone.utc
I see the old warning message now is:
The django.utils.timezone.utc alias is deprecated.
Please update your code to use datetime.timezone.utc instead.
So maybe we should be using datetime.timezone.utc ?
There was a problem hiding this comment.
I had tried that in a54199d but I did not like that since I had to alias datetime.timezone to not collide with django.utils.timezone still used for things like timezone.now()
There was a problem hiding this comment.
I think I'm leaning toward always accessing it like datetime.timezone.utc and then continuing to use timezone.now() like that
There was a problem hiding this comment.
Well I guess on our side we can just decide to consistently use the alias approach for now
from datetime import timezone as datetime_timezone
There was a problem hiding this comment.
Yes, I agree we need to keep timezone.now() but datetime.timezone.utc has issues since we mostly import
from datetime import datetime, timedelta
I think we can use the alias for timezone
from datetime import timezone as datetime_timezone
That will easily for for the existing imports
There was a problem hiding this comment.
Can we pick something shorter than datetime_timezone? tzone?
There was a problem hiding this comment.
Okay, I'll use tzone
No description provided.