Refactor permissions code #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 81.75% 81.68% -0.08%
==========================================
Files 33 32 -1
Lines 2220 2184 -36
==========================================
- Hits 1815 1784 -31
+ Misses 405 400 -5 ☔ View full report in Codecov by Sentry. |
rowanseymour
force-pushed
the
perms
branch
3 times, most recently
from
eeded33
to
71eca1b
Compare
rowanseymour
commented
Jun 11, 2024
|
|
||
|
|
||
| post_migrate.connect(check_all_permissions) | ||
| post_migrate.connect(check_all_group_permissions) |
There was a problem hiding this comment.
@ericnewcomer I have a theory that because signal notification order isn't guaranteed, sometimes granting perms happens before creating them
norkans7
reviewed
Jun 11, 2024
smartmin/users/models.py
Outdated
| from django.utils import timezone | ||
|
|
||
| from .perms import sync_permissions | ||
|
|
||
| post_migrate.connect(sync_permissions) |
There was a problem hiding this comment.
This will now require smartin.users to be in the installed apps to work.
I guess there might be someone using smartmin without that app
can that be moved to smartmin/__init__.py?
There was a problem hiding this comment.
I forgot that smartmin is an app too at the root level... will move
norkans7
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.