Log committed message count for all providers.

Summary:
This lets us easily measure raw sync throughput for all accounts, not just
Gmail ones. Fixes T408.

Test Plan: Run Gmail and Exchange syncs and check that the logs look good.

Reviewers: kav-ya

Reviewed By: kav-ya

Maniphest Tasks: T408

Differential Revision: https://review.inboxapp.com/D437

inbox/mailsync/backends/base.py

@@ -5,7 +5,7 @@
 from sqlalchemy.exc import DataError, IntegrityError
 
 from inbox.log import get_logger
-logger = get_logger()
+log = get_logger()
 from inbox.util.concurrency import retry_and_report_killed
 from inbox.util.itert import partition
 from inbox.models import (Account, Folder, MAX_FOLDER_NAME_LENGTH)
@@ -148,8 +148,9 @@ def create_db_objects(account_id, db_session, log, folder_name, raw_messages,
     return new_uids
 
 
-def commit_uids(db_session, log, new_uids):
+def commit_uids(db_session, new_uids):
     try:
+        log.info(new_committed_message_count=len(new_uids))
         log.info("Committing {0} UIDs".format(len(new_uids)))
         db_session.add_all(new_uids)
         db_session.commit()
@@ -212,7 +213,7 @@ def __init__(self, account, heartbeat=1, retry_fail_classes=[]):
         self.inbox = Queue()
         # how often to check inbox, in seconds
         self.heartbeat = heartbeat
-        self.log = logger.new(component='mail sync', account_id=account.id)
+        self.log = log.new(component='mail sync', account_id=account.id)
         self.account_id = account.id
         self.email_address = account.email_address
         self.provider_name = account.provider

inbox/mailsync/backends/gmail.py

@@ -348,8 +348,7 @@ def download_and_commit_uids(self, crispin_client, folder_name, uids):
                 new_imapuids = create_db_objects(
                     self.account_id, db_session, log, folder_name,
                     raw_messages, self.create_message)
-                commit_uids(db_session, log, new_imapuids)
-                log.info(new_committed_message_count=len(new_imapuids))
+                commit_uids(db_session, new_imapuids)
         return len(new_imapuids)
 
     def __download_queued_threads(self, crispin_client,

inbox/mailsync/backends/imap/generic.py

@@ -373,7 +373,7 @@ def download_and_commit_uids(self, crispin_client, folder_name, uids):
                 new_imapuids = create_db_objects(
                     self.account_id, db_session, log, folder_name,
                     raw_messages, self.create_message)
-                commit_uids(db_session, log, new_imapuids)
+                commit_uids(db_session, new_imapuids)
         return len(new_imapuids)
 
     def update_metadata(self, crispin_client, updated):