Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support release on tag #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support release on tag #98

wants to merge 1 commit into from

Conversation

risdenk
Copy link

@risdenk risdenk commented Aug 7, 2023

First attempt to support release on tag of #97

@risdenk risdenk requested a review from epugh August 7, 2023 15:11
@risdenk risdenk mentioned this pull request Aug 7, 2023
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please do advocate for this issue and ideally submit a patch to get the attention of the maintainers!

@stale stale bot added the wontfix label Mar 17, 2024
@epugh epugh removed the wontfix label Mar 17, 2024
@epugh
Copy link
Member

epugh commented Mar 17, 2024

i was planning to merge this PR when we were gearing up for a splainer release so we can actually test it. Or Solr 10 comes out and we need a release for that... ;-)

I'm going to remove the wontfix label from Stalebot and hope by the time Stalebot looks at it again, we have another release and are going to want to use this functionality.

Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't know hwo to test it without actually doing a release, so sort of waiting till that happens!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants