Do not change qcow+preallocated volumes when moving disks #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base volumes can be of QCOW format and preallocated type when the disk is set with incremental-backup enabled. When moving disks, we now propagate the incremental-backup settings forward to CreateVolume so it will keep these volumes preallocated on the destination storage domain. Bug-Url: https://bugzilla.redhat.com/2211608 Signed-off-by: Arik Hadas <[email protected]>
ahadas
requested review from
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
ahadas
changed the title
bennyz
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base volumes can be of QCOW format and preallocated type when the disk is set with incremental-backup enabled. When moving disks, we now propagate the incremental-backup settings forward to CreateVolume so it will keep these volumes preallocated on the destination storage domain.
Bug-Url: https://bugzilla.redhat.com/2211608