Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE856] optimize binary buffer allocation #953

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FelixYBW
Copy link
Collaborator

@FelixYBW FelixYBW commented Jun 5, 2022

Allocate binary buffer from combine buffer as well
allocate single combine buffer for all partitions

allocate single combine buffer for all partitions
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

@FelixYBW
Copy link
Collaborator Author

FelixYBW commented Jun 5, 2022

there is no performance difference if we set PreferSpill=true. because the memory is allocated once only

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant