-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSSQL Improvements and addition of a domain field lookup #105
base: master
Are you sure you want to change the base?
Conversation
Thanks John. Hopefully Oscar can get it merged soon. |
Awesome, i'll take a look at this tonight! thanks for the help John! |
Hi John,
It would be very helpful separating the 3 on different Pull Requests. The first 2 are very useful and I would like to merge them immediately. However the 3rd one (domain field), I see how it can be useful in some use cases, but seems to me that it may be a bit too specific; in the sense that not all BugLogHQ users would get the intended value from it; or would start reusing it for a different purpose. One of the features I'm currently working on for BugLogHQ 2 is the addition of "user defined properties". It's kinda similar to your addition of Domains, but with the intention to be a bit more customizable for each BugLogHQ deployment. So for example some users may have a "domain" field, while others could have a "userID", or something else. Also the plan is to have multiple properties. Your domains implementation can certainly be used as a "blueprint" or guide for the addition of the new properties, but I don't think it makes much sense to merge it "as-is" at this moment. |
what is the status of this? I would like the sanitization portion of this. |
The improvements on sanitization have been merged into the 1.8 branch, plus with some additional changes to make the sanitization even more customizable. |
Hey oarevalo, i would be interested to be a part of this project, please let me know how can i contribute. |
Hi @abhishekchitransh thanks for the interest! currently the focus is on working on the 2.0 branch, although it is going slow as molasses due to me not having enough time to work on the project. There is plenty to do, but is there any part that interests you more or that you would like to contribute on (front end, back-end, db work, etc) |
Three major things in this pull request.
A few things that have not been completed yet.