Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSQL Improvements and addition of a domain field lookup #105

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jblayter
Copy link

Three major things in this pull request.

  • I have adjusted the DB creation script heavily to make sure that all of the right indexes, primary and foreign keys are in place. It looked like it was generated from a SMSS so that is all done.
  • I have added a domain field with a lookup table.
  • The BugLogService has gotten a lot of love to try and ensure that the data at rest does not contain any credit card data.

A few things that have not been completed yet.

  • Making sure that the mobile view shows the domain
  • Allowing the configuration of the domain field to be auto created. (Currently defaulted to enabled)
  • Adjusting the DB creation scripts for the other DBs

@KrunchMuffin
Copy link
Contributor

Thanks John. Hopefully Oscar can get it merged soon.

@oarevalo
Copy link
Owner

Awesome, i'll take a look at this tonight! thanks for the help John!

@oarevalo
Copy link
Owner

oarevalo commented Oct 2, 2014

Hi John,
I think the updates are really good, but I do have some suggestions. I see that there are basically 3 "features" on this PR:

  • Improved MSSQL creation script
  • Sanitization of sensitive data on buglog client
  • Addition of "domain" field.

It would be very helpful separating the 3 on different Pull Requests. The first 2 are very useful and I would like to merge them immediately. However the 3rd one (domain field), I see how it can be useful in some use cases, but seems to me that it may be a bit too specific; in the sense that not all BugLogHQ users would get the intended value from it; or would start reusing it for a different purpose.

One of the features I'm currently working on for BugLogHQ 2 is the addition of "user defined properties". It's kinda similar to your addition of Domains, but with the intention to be a bit more customizable for each BugLogHQ deployment. So for example some users may have a "domain" field, while others could have a "userID", or something else. Also the plan is to have multiple properties.

Your domains implementation can certainly be used as a "blueprint" or guide for the addition of the new properties, but I don't think it makes much sense to merge it "as-is" at this moment.

@KrunchMuffin
Copy link
Contributor

what is the status of this? I would like the sanitization portion of this.

oarevalo added a commit that referenced this pull request Oct 10, 2014
@oarevalo
Copy link
Owner

The improvements on sanitization have been merged into the 1.8 branch, plus with some additional changes to make the sanitization even more customizable.

@oarevalo oarevalo self-assigned this Oct 10, 2014
@abhishekchitransh
Copy link

Hey oarevalo, i would be interested to be a part of this project, please let me know how can i contribute.

@oarevalo
Copy link
Owner

Hi @abhishekchitransh thanks for the interest! currently the focus is on working on the 2.0 branch, although it is going slow as molasses due to me not having enough time to work on the project. There is plenty to do, but is there any part that interests you more or that you would like to contribute on (front end, back-end, db work, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants