Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and update gitignore #78

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

jmccrae
Copy link
Contributor

@jmccrae jmccrae commented Jan 11, 2024

Non-functional changes to the spec

@michmech
Copy link
Contributor

I'm wondering why you have added all these files into .gitignore:

dmlex-v1.0/specification/examples/examples/source/*

As far as I understand, they are part of the spec's text. They are the code snippets of the examples in the Examples chapter and each of them is included (through <xi:include>) inside one of the XML files in the directory above them. I think they shouldn't be ignored.

@jmccrae
Copy link
Contributor Author

jmccrae commented Jan 12, 2024

The files are the raw forms of the examples and are not included directly in the text.

For example we translate 1.xml (ignored)

<lexicographicResource ...

To 1.xml.xml (committed)

<programlisting>
&lt;lexicographicResource ...

The translation is done here:
https://github.com/oasis-tcs/lexidma/blob/master/dmlex-v1.0/specification/examples/examples/build_source.py

The raw files are from my GitHub
https://github.com/jmccrae/dmlex-converter/tree/main/dmlex/examples

It would have been better to include the raw files directly, but I couldn't make that work.

@michmech
Copy link
Contributor

I get it, thanks, no more objections.

@DavidFatDavidF DavidFatDavidF merged commit cc669ac into oasis-tcs:master Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants